hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (HADOOP-6267) build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
Date Fri, 18 Sep 2009 16:10:16 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon reopened HADOOP-6267:
---------------------------------


I disagree. This is simply better ant style, and the technique is a specific example on the
ant import task documentation:

http://ant.apache.org/manual/CoreTasks/import.html

Part of the ASF principles and the choice of the Apache license is to encourage outside contributions.
While this has no positive (or negative) effect on the project build itself, it makes it easier
to develop code that will later be contributed, and encourages that development to be tightly
coupled to the existing build process. This means there will be less work later to add it
as a contrib/ project, which is good for everyone involved.

Do you have any specific complaints about the patch? If it is zero-sum for the existing codebase
but positive for future contributions, it seems to me like it's a net win.

> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/
dir
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6267
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6267
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative
to the contrib project which is assumed to be inside src/contrib/. We occasionally work on
contrib projects in other repositories until they're ready to contribute. We can use the <dirname>
ant task to do this more correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message