Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 19881 invoked from network); 3 Jun 2009 21:50:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Jun 2009 21:50:20 -0000 Received: (qmail 74754 invoked by uid 500); 3 Jun 2009 21:50:31 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 74678 invoked by uid 500); 3 Jun 2009 21:50:31 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 74668 invoked by uid 99); 3 Jun 2009 21:50:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2009 21:50:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2009 21:50:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5D72D234C044 for ; Wed, 3 Jun 2009 14:50:07 -0700 (PDT) Message-ID: <853705711.1244065807381.JavaMail.jira@brutus> Date: Wed, 3 Jun 2009 14:50:07 -0700 (PDT) From: "Boris Shkolnik (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Updated: (HADOOP-5963) unnecessary exception catch in NNBench In-Reply-To: <2019755216.1243988527378.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Shkolnik updated HADOOP-5963: ----------------------------------- Attachment: Hadoop-5963.patch > unnecessary exception catch in NNBench > -------------------------------------- > > Key: HADOOP-5963 > URL: https://issues.apache.org/jira/browse/HADOOP-5963 > Project: Hadoop Core > Issue Type: Bug > Components: test > Reporter: Boris Shkolnik > Priority: Minor > Attachments: Hadoop-5963.patch > > > NNBench.createControlFiles - catches Exception (even though only IOException is thrown) and then throws a new IOException with message from original. This seems unnecessary and lossfull, because we loose stack info form the original exception. > Suggestion - remove the catch part of try block. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.