Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 8515 invoked from network); 12 Jun 2009 18:58:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Jun 2009 18:58:21 -0000 Received: (qmail 89957 invoked by uid 500); 12 Jun 2009 18:58:32 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 89901 invoked by uid 500); 12 Jun 2009 18:58:32 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 89891 invoked by uid 99); 12 Jun 2009 18:58:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2009 18:58:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2009 18:58:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9C28429A0011 for ; Fri, 12 Jun 2009 11:58:07 -0700 (PDT) Message-ID: <541143805.1244833087638.JavaMail.jira@brutus> Date: Fri, 12 Jun 2009 11:58:07 -0700 (PDT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6017) NameNode and SecondaryNameNode fail to restart because of abnormal filenames. In-Reply-To: <1061422529.1244770207656.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718940#action_12718940 ] Tsz Wo (Nicholas), SZE commented on HADOOP-6017: ------------------------------------------------ I ran unit tests on trunk with 6017_20090611b.patch. The only failed test was TestReduceFetch, which seemed unrelated. Then, I ran TestReduceFetch on a clean trunk. It also failed in both my linux and windows machines. > NameNode and SecondaryNameNode fail to restart because of abnormal filenames. > ----------------------------------------------------------------------------- > > Key: HADOOP-6017 > URL: https://issues.apache.org/jira/browse/HADOOP-6017 > Project: Hadoop Core > Issue Type: Bug > Affects Versions: 0.18.3 > Reporter: Raghu Angadi > Assignee: Tsz Wo (Nicholas), SZE > Priority: Blocker > Fix For: 0.18.4, 0.19.2, 0.20.1, 0.21.0 > > Attachments: 6017_20090611.patch, 6017_20090611b.patch, HADOOP-6017-branch-18.patch > > > SecondaryNameNode (and NameNode) fail to load the edits log. I will include stack trace in next comment. > This is traced to the fact that LeaseManager uses {{String.relaceFirst()}} to replace front of a sting with another string. Unfortunately {{replaceFirst()}} uses regex, though the first argument is {{quoted}} by the code, the second argument is not. (the second arg is not really treated as regex but still gets processed for back references (as in '{{sed s/first/second/g}}') > As Nicholas suggested, it is just simpler to use {{substring()}} to replace part of the string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.