Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 18409 invoked from network); 9 Jun 2009 17:21:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Jun 2009 17:21:57 -0000 Received: (qmail 66174 invoked by uid 500); 9 Jun 2009 17:13:32 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 66149 invoked by uid 500); 9 Jun 2009 17:13:32 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 66131 invoked by uid 99); 9 Jun 2009 17:13:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2009 17:13:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2009 17:13:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6DAD7234C004 for ; Tue, 9 Jun 2009 10:13:07 -0700 (PDT) Message-ID: <47433930.1244567587435.JavaMail.jira@brutus> Date: Tue, 9 Jun 2009 10:13:07 -0700 (PDT) From: "Jingkei Ly (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5589) TupleWritable: Lift implicit limit on the number of values that can be stored In-Reply-To: <729859116.1238156210491.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717752#action_12717752 ] Jingkei Ly commented on HADOOP-5589: ------------------------------------ It looks like you would probably need to backport HADOOP-3721 as well, as this incorporated a change to CompositeRecordReader.JoinCollector that removed the limitation from using longs. > TupleWritable: Lift implicit limit on the number of values that can be stored > ----------------------------------------------------------------------------- > > Key: HADOOP-5589 > URL: https://issues.apache.org/jira/browse/HADOOP-5589 > Project: Hadoop Core > Issue Type: Improvement > Components: mapred > Affects Versions: 0.19.1 > Reporter: Jingkei Ly > Assignee: Jingkei Ly > Fix For: 0.21.0 > > Attachments: HADOOP-5589-1.patch, HADOOP-5589-2.patch, HADOOP-5589-3.patch, HADOOP-5589-4.patch, HADOOP-5589-4.patch > > > TupleWritable uses an instance field of the primitive type, long, which I presume is so that it can quickly determine if a position has been written to in its array of Writables (by using bit-shifting operations on the long field). The problem with this is that it implies that there is a maximum limit of 64 values you can store in a TupleWritable. > An example of a use-case where I think this would be a problem is if you had two MR jobs with over 64 reduces tasks and you wanted to join the outputs with CompositeInputFormat - this will probably cause unexpected results in the current scheme. > At the very least, the 64-value limit should be documented in TupleWritable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.