Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 24901 invoked from network); 18 Jun 2009 18:04:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 18 Jun 2009 18:04:28 -0000 Received: (qmail 6229 invoked by uid 500); 18 Jun 2009 18:04:38 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 6168 invoked by uid 500); 18 Jun 2009 18:04:38 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 6116 invoked by uid 99); 18 Jun 2009 18:04:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2009 18:04:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2009 18:04:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 71171234C044 for ; Thu, 18 Jun 2009 11:04:07 -0700 (PDT) Message-ID: <1887110056.1245348247449.JavaMail.jira@brutus> Date: Thu, 18 Jun 2009 11:04:07 -0700 (PDT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6051) distcp does not skip copying file if we are updating single file In-Reply-To: <1912110496.1245141247516.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721384#action_12721384 ] Tsz Wo (Nicholas), SZE commented on HADOOP-6051: ------------------------------------------------ > I guess we need to change the doc. OR Do we really need to change the behaviour of distcp ? Thanks for checking this Ravi. The doc actually is not clear about copying a single file, which, as always, is a not-so-useful special case. We have freedom to do either way. It is probably better to minimize the code complexity since distcp is already complicated enough. > distcp does not skip copying file if we are updating single file > ---------------------------------------------------------------- > > Key: HADOOP-6051 > URL: https://issues.apache.org/jira/browse/HADOOP-6051 > Project: Hadoop Core > Issue Type: Bug > Components: tools/distcp > Affects Versions: 0.21.0 > Reporter: Ravi Gummadi > Fix For: 0.21.0 > > > distcp doesn't skip copying file when we do -update on single file if the destfile already exists. > When we do > hadoop distcp -update srcfilename destfilename > it seems to be comparing checksums of srcfilename and destfilename/srcfilename and so skip is not done. It should compare checksums of srcfilename and destfilename. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.