Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 74112 invoked from network); 15 Jun 2009 18:00:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Jun 2009 18:00:19 -0000 Received: (qmail 46664 invoked by uid 500); 15 Jun 2009 18:00:29 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 46603 invoked by uid 500); 15 Jun 2009 18:00:29 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 46593 invoked by uid 99); 15 Jun 2009 18:00:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2009 18:00:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2009 18:00:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5D317234C044 for ; Mon, 15 Jun 2009 11:00:07 -0700 (PDT) Message-ID: <1722314327.1245088807372.JavaMail.jira@brutus> Date: Mon, 15 Jun 2009 11:00:07 -0700 (PDT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5700) INode.getPathComponents throws NPE when given a non-absolute path In-Reply-To: <971712353.1239994215098.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719669#action_12719669 ] Tsz Wo (Nicholas), SZE commented on HADOOP-5700: ------------------------------------------------ +1 the patch is good. Thanks, Todd! > INode.getPathComponents throws NPE when given a non-absolute path > ----------------------------------------------------------------- > > Key: HADOOP-5700 > URL: https://issues.apache.org/jira/browse/HADOOP-5700 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Fix For: 0.21.0 > > Attachments: HADOOP-5700-v2.txt, HADOOP-5700.txt > > > If you pass a path that doesn't start with '/' to INode.getPathComponents, it throws a NullPointerException. Instead it should throw IllegalArgumentException to make it clear that absolute paths are required in this code. > The attached patch fixes this, clarifies, the javadoc, and adds a test case. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.