hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5963) unnecessary exception catch in NNBench
Date Sat, 06 Jun 2009 06:50:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716840#action_12716840
] 

Hadoop QA commented on HADOOP-5963:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409819/Hadoop-5963.patch
  against trunk revision 782083.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/471/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/471/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/471/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/471/console

This message is automatically generated.

> unnecessary exception catch in NNBench
> --------------------------------------
>
>                 Key: HADOOP-5963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5963
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Boris Shkolnik
>            Priority: Minor
>         Attachments: Hadoop-5963.patch
>
>
> NNBench.createControlFiles - catches Exception (even though only IOException is thrown)
and then throws a new IOException with message from original. This seems unnecessary and lossfull,
because we loose stack info form the original exception.
> Suggestion - remove the catch part of try block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message