hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5963) unnecessary exception catch in NNBench
Date Wed, 03 Jun 2009 22:12:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716082#action_12716082
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5963:
------------------------------------------------

+1

> unnecessary exception catch in NNBench
> --------------------------------------
>
>                 Key: HADOOP-5963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5963
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Boris Shkolnik
>            Priority: Minor
>         Attachments: Hadoop-5963.patch
>
>
> NNBench.createControlFiles - catches Exception (even though only IOException is thrown)
and then throws a new IOException with message from original. This seems unnecessary and lossfull,
because we loose stack info form the original exception.
> Suggestion - remove the catch part of try block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message