hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6079) In DataTransferProtocol, the serialization of proxySource is not consistent
Date Thu, 18 Jun 2009 20:16:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721450#action_12721450
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6079:
------------------------------------------------

{noformat}
     [exec] -1 overall.
     [exec]
     [exec] +1 @author. The patch does not contain any @author tags.
     [exec]
     [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
     [exec] Please justify why no tests are needed for this patch.
     [exec]
     [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
     [exec]
     [exec] +1 javac. The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec] +1 release audit. The applied patch does not increase the total number of release
audit warnings.
{noformat}
Ran related unit tests locally. Everything works fine.

> In DataTransferProtocol, the serialization of proxySource is not consistent
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-6079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6079
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 6079_20090618.patch
>
>
> In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode
but then the serialized value is read as a DatanodeInfo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message