hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6004) BlockLocation deserialization is incorrect
Date Mon, 15 Jun 2009 18:36:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719691#action_12719691
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6004:
------------------------------------------------

+1 patch looks good.

A nit: It is better to replace the existing codes
{code}
Text t = new Text();
t.readFields(in);
variable = t.toString();
{code}
by
{code}
variable = Text.readString(in);
{code}
for preventing object creation.

> BlockLocation deserialization is incorrect
> ------------------------------------------
>
>                 Key: HADOOP-6004
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6004
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HADOOP-6004.patch, HADOOP-6004.patch
>
>
> The {{readFields}} method of {{BlockLocation}} does not correctly allocate new arrays
for topologyPaths and hosts. Patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message