hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sharad Agarwal (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5833) SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to SequenceFileOutputFormat
Date Wed, 10 Jun 2009 06:39:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717944#action_12717944
] 

Sharad Agarwal commented on HADOOP-5833:
----------------------------------------

The current patch does not compile as it references the super from a static method.
Also, OutputFormat.setOutputPath is a static method and it sets the output path on the job
configuration as expected. The child classes don't need to override this functionality.

> SequenceFileOutputFormat.setOutputPath(Job,Path) should set the Output Format Class to
SequenceFileOutputFormat
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5833
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.20.0
>            Reporter: Daniel Leffel
>            Priority: Minor
>         Attachments: hadoop-5833.patch
>
>
> The documentation references that OutputFormat.setOutputPath(Job,Path) sets the job up
appropriately. However, that's not the case for SequenceFileOutputFormat.setOutputPath(Job,Path).
This has tripped up more than one new user. SequenceFileOutputFormat.setOutputPath(Job,Path)
should call both the superclass method as well as job.setOutputFormatClass(SequenceFileOutputFormat.class);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message