hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michele (aka pirroh) Catasta (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2366) Space in the value for dfs.data.dir can cause great problems
Date Tue, 30 Jun 2009 12:20:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725591#action_12725591
] 

Michele (aka pirroh) Catasta commented on HADOOP-2366:
------------------------------------------------------

Tsz Wo: build successful for "ant test"


{code} 
-1 overall.  
+1 @author.  The patch does not contain any @author tags.
+1 tests included.  The patch appears to include 3 new or modified tests.
+1 javadoc.  The javadoc tool did not generate any warning messages.
 -1 javac.  The applied patch generated 64 javac compiler warnings (more than the trunk's
current 124 warnings).
+1 findbugs.  The patch does not introduce any new Findbugs warnings.
+1 release audit.  The applied patch does not increase the total number of release audit warnings.
{code}


for "ant test-patch". No idea about the warnings, probably I messed up something in forrest/findbugs?

> Space in the value for dfs.data.dir can cause great problems
> ------------------------------------------------------------
>
>                 Key: HADOOP-2366
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2366
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Ted Dunning
>            Assignee: Michele (aka pirroh) Catasta
>         Attachments: HADOOP-2366.patch
>
>
> The following configuration causes problems:
> <property>
>   <name>dfs.data.dir</name>
>   <value>/mnt/hstore2/hdfs, /home/foo/dfs</value>  
>   <description>
>   Determines where on the local filesystem an DFS data node  should store its bl
> ocks.  If this is a comma-delimited  list of directories, then data will be stor
> ed in all named  directories, typically on different devices.  Directories that 
> do not exist are ignored.  
>   </description>
> </property>
> The problem is that the space after the comma causes the second directory for storage
to be " /home/foo/dfs" which is in a directory named <SPACE> which contains a sub-dir
named "home" in the hadoop datanodes default directory.  This will typically cause the user's
home partition to fill, but will be very hard for the user to understand since a directory
with a whitespace name is hard to understand.
> My proposed solution would be to trimLeft all path names from this and similar property
after splitting on comma.  This still allows spaces in file and directory names but avoids
this problem. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message