hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6017) NameNode and SecondaryNameNode fail to restart because of abnormal filenames.
Date Fri, 12 Jun 2009 03:48:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718705#action_12718705
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6017:
------------------------------------------------

{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}

> NameNode and SecondaryNameNode fail to restart because of abnormal filenames.
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-6017
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6017
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.18.3
>            Reporter: Raghu Angadi
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.4, 0.19.2, 0.20.1, 0.21.0
>
>         Attachments: 6017_20090611.patch, 6017_20090611b.patch, HADOOP-6017-branch-18.patch
>
>
> SecondaryNameNode (and NameNode) fail to load the edits log.  I will include stack trace
in next comment.
> This is traced to the fact that LeaseManager uses {{String.relaceFirst()}} to replace
front of a sting with another string. Unfortunately {{replaceFirst()}} uses regex, though
the first argument is {{quoted}} by the code, the second argument is not. (the second arg
is not really treated as regex but still gets processed for back references (as in '{{sed
s/first/second/g}}')
> As Nicholas suggested, it is just simpler to use {{substring()}} to replace part of the
string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message