hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.
Date Tue, 02 Jun 2009 17:23:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715596#action_12715596
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5953:
------------------------------------------------

{noformat}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}
The patch removes two @Deprecates annotations.  No new tests added.

> KosmosFileSystem.isDirectory() should not be deprecated.
> --------------------------------------------------------
>
>                 Key: HADOOP-5953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 5953_20090601.patch
>
>
> FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for
KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message