hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sharad Agarwal (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5694) Change org.apache.hadoop.examples.dancing to use new mapreduce api
Date Fri, 05 Jun 2009 07:54:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716528#action_12716528
] 

Sharad Agarwal commented on HADOOP-5694:
----------------------------------------

Minor comment on the patch:
The code setting the values of depth, width and height is duplicated. Can we define these
say in constant variables ?

> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
>                 Key: HADOOP-5694
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5694
>             Project: Hadoop Core
>          Issue Type: Sub-task
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>         Attachments: patch-5694.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message