hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5925) EC2 scripts should exit on error
Date Fri, 26 Jun 2009 13:35:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724521#action_12724521

Tom White commented on HADOOP-5925:

     [exec] -1 overall.  
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]     -1 javac.  The applied patch generated 64 javac compiler warnings (more than
the trunk's current 124 warnings).
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.

There are no tests for the current EC2 scripts, so I tested this manually by running through
starting a cluster, running a job, and shutting the cluster down. I tested a failure by setting
an invalid key name.

The -1 for javac is odd, since the number went down according to the message, and furthermore
this patch doesn't change any Java code.

> EC2 scripts should exit on error
> --------------------------------
>                 Key: HADOOP-5925
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5925
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: contrib/ec2
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: hadoop-5925.patch
> For example, if an ec2-authorize command fails the script should stop so that the problem
is easier to debug.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message