hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5981) HADOOP-2838 doesnt work as expected
Date Tue, 09 Jun 2009 12:10:07 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amar Kamat updated HADOOP-5981:
-------------------------------

    Attachment: HADOOP-5981-v2.0.patch

Attaching a new patch that 
# inherits the tastracker's env variable value for substitution 
# fixes the substitution code
# fixes the testcase
# adds meaningful diagnostic information upon faulty env

Result of test-patch
[exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.

Tested this patch on a single node cluster and works as expected. Here is what I did
||No||Param||Output||
|1|A|Error seen on webui and job fails|
|2|A=B|Child env has a parameter A set to B|
|2|A=$A:B|Child env has a parameter A set to :B|
|2|LD_LIBRARY_PATH=$LD_LIBRARY_PATH:B|Child env has B appended to the modified LD (work dir)|
|2|PATH=$PATH:B|Child env has PATH inherited from tt and appended B|
Running ant test now

> HADOOP-2838 doesnt work as expected
> -----------------------------------
>
>                 Key: HADOOP-5981
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5981
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5981-v1.1-branch-20.patch, HADOOP-5981-v1.1.patch, HADOOP-5981-v2.0.patch
>
>
> The substitution feature i.e X=$X:/tmp doesnt work as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message