hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5952) Hudson -1 wording change
Date Mon, 01 Jun 2009 23:17:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715298#action_12715298
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5952:
------------------------------------------------

> ... Please justify why no tests are needed for this patch...

How about change it to "... Please justify why no new tests are needed for this patch..."?

In some cases, a patch may fix problems with existing failing unit tests, or it is a performance
improvement (so the correctness is tested by the existing tests).

> Hudson -1 wording change
> ------------------------
>
>                 Key: HADOOP-5952
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5952
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: build
>            Reporter: gary murry
>            Assignee: Giridharan Kesavan
>            Priority: Minor
>
> The wording should be changed when Hudson -1 a patch for no unit test updates.  New wording
to be be added in comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message