hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-6003) AspectJ framework for HDFS code and tests
Date Fri, 19 Jun 2009 22:04:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722045#action_12722045
] 

Konstantin Boudnik edited comment on HADOOP-6003 at 6/19/09 3:02 PM:
---------------------------------------------------------------------

Slightly different version of the original patch:
conf/fi-site.xml is moved to src/test. build.xml is modified to copy it for test runs.
<iajc> task definition is moved inside of the target 'injectfaults' to guarantee that
it always defined

Couldn't reproduce the issue with 
{noformat}
ant clean
{noformat}
works for me every time. Is it possible that you had some files permission issues?

Wrt to TestFileCreation: I have ran this test many times and seen a failure only once. The
problem with this test is that while I can confirm that faults methods are called they aren't
called frequent enough (i.e. < 80 calls during the test execution) to reach the necessary
threshold of 1% to inject a fault. In other words, the instrumented isn't being called often
enough. I'd suggest to run TestDirectoryScanner instead where these instrumented functions
are called pretty often so the test fails on every run.


      was (Author: cos):
    Slightly different version of the original patch:
conf/fi-site.xml is moved to src/test. build.xml is modified to copy it for test runs.
<iajc> task definition is moved inside of the target 'injectfaults' to guarantee that
it always defined

Couldn't reproduce the issue with 
{noformat}
ant clean
{noformat}
works for me every time. Is it possible that you had some files permission issues?

Wrt to TestFileCreation: I have ran this test many times and seen a failure only once. The
problem with this test is that while I can confirm that faults methods are called they weren't
called frequent enough (i.e. < 80 called during the test execution) to reach the necessary
threshold of 1% to inject a fault. In other words, the instrumented isn't being called often
enough. I'd suggest to run TestDirectoryScanner instead where these instrumented functions
are called pretty often so the test fails on every run.

  
> AspectJ framework for HDFS code and tests
> -----------------------------------------
>
>                 Key: HADOOP-6003
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6003
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6003.patch, HADOOP-6003.patch, HADOOP-6003.patch, HADOOP-6003.patch,
HADOOP-6003.patch, HADOOP-6003.sh, HADOOP-6003.sh
>
>
> This subtask takes care about HDFS part of Hadoop only. Others will be added later as
needed: it will include only new aspects development and modifications of build.xml file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message