Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 1656 invoked from network); 25 May 2009 05:04:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 May 2009 05:04:18 -0000 Received: (qmail 57889 invoked by uid 500); 25 May 2009 04:42:17 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 57854 invoked by uid 500); 25 May 2009 04:42:10 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 57844 invoked by uid 99); 25 May 2009 04:42:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 May 2009 04:42:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 May 2009 04:42:06 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9581D234C004 for ; Sun, 24 May 2009 21:41:45 -0700 (PDT) Message-ID: <848165310.1243226505598.JavaMail.jira@brutus> Date: Sun, 24 May 2009 21:41:45 -0700 (PDT) From: "dhruba borthakur (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5859) FindBugs : fix "wait() or sleep() with locks held" warnings in hdfs In-Reply-To: <474124716.1242434385591.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712631#action_12712631 ] dhruba borthakur commented on HADOOP-5859: ------------------------------------------ > 2) dataQueue lock and ackQueue lock are merged into one Is this done to make the code simpler? Or was there some race condition that this fixes? > FindBugs : fix "wait() or sleep() with locks held" warnings in hdfs > ------------------------------------------------------------------- > > Key: HADOOP-5859 > URL: https://issues.apache.org/jira/browse/HADOOP-5859 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Kan Zhang > Assignee: Kan Zhang > Attachments: 5859-21.patch, 5859-22.patch, 5859-4.patch, 5859-5.patch, 5859-8.patch > > > This JIRA fixes the following warnings: > SWL org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closeInternal() calls Thread.sleep() with a lock held > TLW wait() with two locks held in org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal() > TLW wait() with two locks held in org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.flushInternal() > TLW wait() with two locks held in org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.writeChunk(byte[], int, int, byte[]) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.