Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <839412423.1242784905588.JavaMail.jira@brutus>
Date: Tue, 19 May 2009 19:01:45 -0700 (PDT)
From: "Konstantin Boudnik (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Updated: (HADOOP-5867) Cleaning NNBench* off javac warnings
In-Reply-To: <1714988474.1242702165597.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-5867:
---------------------------------------

    Attachment: HADOOP-5867.patch

All but one comments from the reviewer were taken into consideration and fixed.
I'm hesitant to used suggestion from the review and modify the code in question to
  success = fileSys.rename(...)
because rename() might return false in three cases our of four existing exit points.

More generic question is: are we trying to count both false and true return as success and only exception throwing as a failure?

> Cleaning NNBench* off javac warnings
> ------------------------------------
>
>                 Key: HADOOP-5867
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5867
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5867.patch, HADOOP-5867.patch, HADOOP-5867.patch
>
>
> These files have a number of javac 'class depricated' warnings 
>   src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBench.java
>   src/test/hdfs-with-mr/org/apache/hadoop/hdfs/NNBenchWithoutMR.java
> It is possible to fix most of them plus make some readability improvements on the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.