Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1845073474.1243624365540.JavaMail.jira@brutus>
Date: Fri, 29 May 2009 12:12:45 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-5700) INode.getPathComponents throws NPE
 when given a non-absolute path
In-Reply-To: <971712353.1239994215098.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714556#action_12714556 ] 

Konstantin Shvachko commented on HADOOP-5700:
---------------------------------------------

No, RuntimeException is an indication of a bug. And replacing one bug by another does not solve the problem.
I think in addition to what I proposed we should also call {{DFSUtil.isValidName(src)}} for all methods in {{FSNamesystem}} which take a path name string as a parameter. This is done correctly in {{startFileInternal()}}, {{renameToInternal()}} and {{mkdirsInternal()}}, but not in {{getFileInfo()}} or {{getBlockLocations()}}.
I propose to fix this jira as I proposed, if it works of course, which I didn't check. And create a new one, which would make sure {{DFSUtil.isValidName(src)}} is called everywhere it should be.


> INode.getPathComponents throws NPE when given a non-absolute path
> -----------------------------------------------------------------
>
>                 Key: HADOOP-5700
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5700
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5700.txt
>
>
> If you pass a path that doesn't start with '/' to INode.getPathComponents, it throws a NullPointerException. Instead it should throw IllegalArgumentException to make it clear that absolute paths are required in this code.
> The attached patch fixes this, clarifies, the javadoc, and adds a test case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.