Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1575816307.1242285885644.JavaMail.jira@brutus>
Date: Thu, 14 May 2009 00:24:45 -0700 (PDT)
From: =?utf-8?Q?Jord=C3=A0_Polo_=28JIRA=29?= <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-5679) Resolve findbugs warnings in
 core/streaming/pipes/examples
In-Reply-To: <880569008.1239784455231.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HADOOP-5679?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D127=
09295#action_12709295 ]=20

Jord=C3=A0 Polo commented on HADOOP-5679:
------------------------------------

Running local jobs seems to fail for me since this patch was applied ("Mkdi=
rs failed to create...").

The new code checks if either mkdirs() on hadoop.tmp.dir failed OR if it is=
n't a directory... but it doesn't take into account that the directory may =
already exist. If the directory existed before, it will always fail and exi=
t since mkdirs() only returns "true" if it is able to create the directory.

Wouldn't an AND be more appropriate here? I mean {{(!b && !tmpDir.isDirecto=
ry())}} instead of {{(!b || !tmpDir.isDirectory())}} in src/core/org/apache=
/hadoop/util/RunJar.java, line 111.

> Resolve findbugs warnings in core/streaming/pipes/examples
> ----------------------------------------------------------
>
>                 Key: HADOOP-5679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5679
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: hadoop-5679.patch
>
>
> Towards a solution for HADOOP-5628, we need to resolve all findbugs warni=
ngs. This jira will try to resolve the findbugs warnings where ever possibl=
e and suppress them where resolution is not possible.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.