Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1537673828.1242704085659.JavaMail.jira@brutus>
Date: Mon, 18 May 2009 20:34:45 -0700 (PDT)
From: "Konstantin Boudnik (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Updated: (HADOOP-5868) FSDirectory.renameTo(String, String)
 has unclear logic around unprotectedRenameTo() call
In-Reply-To: <1361740705.1242702885728.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-5868:
---------------------------------------

    Status: Patch Available  (was: In Progress)

To improve the readability of some methods

> FSDirectory.renameTo(String, String) has unclear logic around unprotectedRenameTo() call
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5868
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5868
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>            Priority: Minor
>         Attachments: HADOOP-5868.patch
>
>
> Current implementation of renameTo(String, String) has this piece of the code at the end:
> ...
>     if (!unprotectedRenameTo(src, dst, now))
>       return false;
>     fsImage.getEditLog().logRename(src, dst, now);
>     return true;
> }
> The logic of the code isn't very clear from a very sight. A slight modification is recommended to make it more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.