Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 34681 invoked from network); 29 May 2009 21:54:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 May 2009 21:54:58 -0000 Received: (qmail 30774 invoked by uid 500); 29 May 2009 21:55:10 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 30700 invoked by uid 500); 29 May 2009 21:55:09 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 30681 invoked by uid 99); 29 May 2009 21:55:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2009 21:55:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2009 21:55:06 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8FD1C234C04B for ; Fri, 29 May 2009 14:54:45 -0700 (PDT) Message-ID: <115724510.1243634085588.JavaMail.jira@brutus> Date: Fri, 29 May 2009 14:54:45 -0700 (PDT) From: "Hairong Kuang (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Created: (HADOOP-5943) OUtils#copyBytes methods should not close streams that are passed in as parameters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org OUtils#copyBytes methods should not close streams that are passed in as parameters ---------------------------------------------------------------------------------- Key: HADOOP-5943 URL: https://issues.apache.org/jira/browse/HADOOP-5943 Project: Hadoop Core Issue Type: Bug Components: io Reporter: Hairong Kuang Fix For: 0.21.0 The following methods in IOUtils close the streams that are passed in as parameters. Calling these methods can easily trigger findbug OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION). A good practice should be to close a stream in the same method where the stream is opened. public static void copyBytes(InputStream in, OutputStream out, int buffSize, boolean close) public static void copyBytes(InputStream in, OutputStream out, Configuration conf, boolean close) These methods should be deprecated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.