hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5823) Handling javac "deprecated" warning for using UTF8
Date Wed, 13 May 2009 23:58:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709220#action_12709220
] 

Raghu Angadi commented on HADOOP-5823:
--------------------------------------

ant test-patch :
{noformat}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
{noformat}

> Handling javac "deprecated" warning for using UTF8
> --------------------------------------------------
>
>                 Key: HADOOP-5823
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5823
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5823.patch, HADOOP-5823.patch
>
>
> o.a.h.io.UTF8 is deprecated but is still used in multiple places. FSEditLog.java has
40 UTF8 related warnings. I don't think it is feasible to avoid using UTF8 in FSEditLog.java.

> Two options to get rid of these warnings :
>   1. use @SupressWarnings at each use of UTF or for enclosing class.
>   2. define a wrapper class {{DeprecatedUTF8}} that is not {{@deprecated}}. 
> I prefer the second option in this case since it keeps FSEditLog.java and other places
clean and still makes it explicit that a deprecated class is used.
> This is part of spring cleaning effort to remove warnings in javac. I will attach a patch
for the second option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message