hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5782) Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
Date Fri, 08 May 2009 01:59:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707207#action_12707207
] 

Suresh Srinivas commented on HADOOP-5782:
-----------------------------------------

Tests not included because the patch just formats the code. Here is the testpatch result:
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.

> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting
patch
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5782
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5782
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java,
some formatting changes are made. These changes make porting patches to BlockManager.java
difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message