hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5858) Eliminate UTF8 and fix warnings in test/hdfs-with-mr package
Date Sat, 16 May 2009 01:30:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710049#action_12710049
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5858:
------------------------------------------------

Changes look good to me. Thanks, Konstantin.

Want to mention that the following codes in the AccumulatingReducer is inefficient: The sSum
string should be constructed by StringBuilder for reducing unnecessary object creations. 
Of course, this is an existing problem and has nothing to do with the patch or this issue.
{code}
       String sSum = "";
       while (values.hasNext())
         sSum += values.next().toString() + ";";
{code}


> Eliminate UTF8 and fix warnings in test/hdfs-with-mr package
> ------------------------------------------------------------
>
>                 Key: HADOOP-5858
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5858
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.19.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: hdfsWithMR.patch, hdfsWithMR.patch
>
>
> Replace UTF8 with Text and fix java warnings not related to deprecated mapred api.
> Warnings related to the deprecated map reduce api should probably be targeted in a separate
unified approach.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message