hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5737) UGI checks in testcases are broken
Date Thu, 07 May 2009 04:42:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706718#action_12706718
] 

Amar Kamat commented on HADOOP-5737:
------------------------------------

Hey Arun thanks for looking. JobInProgress requires access to JobTracker's conf for 
# Making connections to namenode 
# Passing it to other classes like CleanupQueue etc. 

For case #1, JobTracker.getFileSystem() makes sense but for case #2,  its better to pass the
conf. Hence the {{getConf()}} api. 

bq. please document the rationale for these apis too for posterity. 
If we keep the {{getConf()}} api, do we need any documentation for this?


> UGI checks in testcases are broken
> ----------------------------------
>
>                 Key: HADOOP-5737
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5737
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Amar Kamat
>         Attachments: HADOOP-5737-v1.3.patch
>
>
> While running {{TestMiniMRWithDFSWithDistinctUsers}}, I used this patch to test the ugi
checks 
> {code}
> Index: src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java
> ===================================================================
> --- src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(revision
768189)
> +++ src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(working copy)
> @@ -40,6 +40,7 @@
>      if (LOG.isDebugEnabled()) {
>        LOG.debug("ugi=" + ugi);
>      }
> +    LOG.info("ugi=" + ugi);
>  
>      if (ugi != null) {
>        user = ugi.getUserName();
> {code}
> While initializing a job, the ugi information should point to jobtracker as jobtracker
does a dfs read. But today we will see that the log shows _pi_ as the caller instead of the
jobtracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message