hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sharad Agarwal (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5896) Remove the dependency of GenericOptionsParser on Option.withArgPattern
Date Wed, 27 May 2009 06:12:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713432#action_12713432
] 

Sharad Agarwal commented on HADOOP-5896:
----------------------------------------

Tested after removing lib/commons-cli jar, all core tests passed.
test-patch results:
 -1 overall.
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]     +1 tests included.  The patch appears to include 4 new or modified tests.
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]     -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from
the contents of the lib directories.
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.

eclipse classpath is expected to fail as mentioned in previous comment.
Should we commit this ?


> Remove the dependency of GenericOptionsParser on Option.withArgPattern
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-5896
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5896
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Sharad Agarwal
>            Assignee: Sharad Agarwal
>         Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch
>
>
> commons-cli released version does not have Option.withArgPattern API

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message