hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5700) INode.getPathComponents throws NPE when given a non-absolute path
Date Wed, 27 May 2009 23:29:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713798#action_12713798
] 

Raghu Angadi commented on HADOOP-5700:
--------------------------------------

> I triggered it by calling namenode.getFileInfo() on a relative path from within my thrift
contrib code (HADOOP-4707).

Thanks Todd. That implies user can trigger it. So namenode.getFileInfo(null) might still trigger
an NPE even after the patch. 

Do you think NN should sanity check user input at the highest level (in NameNode.java) and
throw an IOException? 
Or in this particular case, not having "/" at the beginning is like giving random string for
path.. which should trigger "FileNotFoundException" and not a runtime exception IMO. But another
IOException with helpful message is fine too.

> INode.getPathComponents throws NPE when given a non-absolute path
> -----------------------------------------------------------------
>
>                 Key: HADOOP-5700
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5700
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5700.txt
>
>
> If you pass a path that doesn't start with '/' to INode.getPathComponents, it throws
a NullPointerException. Instead it should throw IllegalArgumentException to make it clear
that absolute paths are required in this code.
> The attached patch fixes this, clarifies, the javadoc, and adds a test case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message