hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] Commented: (HADOOP-5732) SFTP FileSystem
Date Wed, 06 May 2009 09:11:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706360#action_12706360
] 

Íñigo Goiri commented on HADOOP-5732:
-------------------------------------

Thanks for your comments, I've solved some of the the issues and I would want to comment some
of them.
* Throwing a RuntimeException (SFTPException) from FileSystem methods seems excessive; IOException
should suffice.
It was based on the method used in the FTP FileSystem which used a runtime exception. Should
I use IOException then?
For example if it throws an IOException at "exists" method, the API should be changed, I think
that's why they used FTPException. In this case, should I just solve the exception locally?
or throwing the SFTPException?

* SFTPInputStream could equivalently and more succinctly extend FSInputStream. It can probably
be a package-private class.
Done, it extends FSInputStream. Should I modify something in order to do it package-private?

* The patch should update the ivy configs if it adds a jsch dependency. I'm sorry, but I have
no good references on how to do this.
FTPFileSystem used commons-net, which uses  JSch, in theory, the dependency should be automatically
resolved. Anyone knows if it is OK or should I add something?

* Defaulting "recursive" to true in delete might be too aggressive.
Done.

* Note that delete(Path f) has been deprecated and removed in trunk, so at least two of the
delete overrides can be removed
I work with hadoop 0.19, which defines this methods, I prefer specifying it as deprecated.

* Re-thrown exceptions should retain the original cause, not just the message (e.g. rename)
Done.

* Any particular reason for not supporting setting the working directory?
It is the same problem with FTPFileSystem:
"Directory on the server is changed to the parent directory of the file. The FTP client connection
is closed when close() is called on the FSDataInputStream."




> SFTP FileSystem
> ---------------
>
>                 Key: HADOOP-5732
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5732
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: fs
>         Environment: Any environment
>            Reporter: Íñigo Goiri
>            Priority: Minor
>         Attachments: HADOOP-FS-SFTP.patch, SFTPException.java, SFTPFileSystem.java, SFTPInputStream.java
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I have implemented a FileSystem that supports SFTP. It uses JSch (http://www.jcraft.com/jsch/)
in order to manage SFTP.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message