hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5866) Move DeprecatedUTF8 to o.a.h.hdfs
Date Tue, 19 May 2009 20:11:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Raghu Angadi updated HADOOP-5866:
---------------------------------

    Attachment: HADOOP-5866.patch

Thanks Nicholas for the review.

Updated patch is attached. The previous one was incomplete. NamespaceInfo.java was not updated.

ant test-patch: {noformat}
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]
  {noformat}

> Move DeprecatedUTF8 to o.a.h.hdfs
> ---------------------------------
>
>                 Key: HADOOP-5866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5866
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.21.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5866.patch, HADOOP-5866.patch, HADOOP-5866.patch
>
>
> HADOOP-5823 added {{DeprecatedUTF8}} class as a wrapper for UTF8. Though UTF8 is deprecated,
it is used in many places and most likely will continue to be used for quite sometime. My
initial thought was that other packages might want to use the wrapper {{DeprecatedUTF8}}.

> But the current suggestion (discussed in HADOOP-5823) is to move the class to o.a.h.hdfs.
> Alternately we could have just use "@SuppressWarnings" rather than introducing a new
class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message