hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5877) Fix javac warnings in TestHDFSServerPorts, TestCheckpoint, TestNameEditsConfig, TestStartup and TestStorageRestore
Date Wed, 20 May 2009 20:50:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Homan updated HADOOP-5877:
--------------------------------

    Attachment: HADOOP-5877.patch

Patch to implement these fixes:
Test patch:
{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 16 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}

* Fixes all of the javac warnings in the above mentioned files.  These all related to use
of the deprecated secondary name node.  These were fixed by suppressing the warning on the
method it emanated from, rather than applying the annotation to the entire file.
* Of note, in two places the SecondaryNameNode was a return type of a method and due to a
bug in Java (http://bugs.sun.com/view_bug.do?bug_id=6460147) the warning suppression doesn't
work and still generates a javac warning.  This has been noted in the code.
* In {{TestHDFSServerPorts}} the offending warning was suppressed and a new test that uses
the backup node to test the equivalent functionality added.  This is the best approach to
take with replacing these tests with backupnode versions until the secondary namenode is removed,
but doing so on the other cases is beyond the scope of this JIRA.
* General clean up of the {{TestHDFSServerPorts}} class.
* As part of the new test BackupNode had to become a public rather than package-private class
in order to make it available for testing.

> Fix javac warnings in TestHDFSServerPorts, TestCheckpoint, TestNameEditsConfig, TestStartup
and TestStorageRestore
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5877
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5877
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HADOOP-5877.patch
>
>
> All of these warnings relate to use of the deprecated SecondaryNameNode.  Since the 2ndNN
isn't going to be excised anytime soon, these should all be suppressed with as narrow of a
suppression scope as possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message