hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5823) Handling javac "deprecated" warning for using UTF8
Date Mon, 18 May 2009 23:08:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710532#action_12710532
] 

Doug Cutting commented on HADOOP-5823:
--------------------------------------

> UTF8 is currently used in many places.

Yes, but FSEditLog has been identified as a place that UTF8 will continue to be used for a
long time yet, long-enough that we want to squash the warnings there.  Are there other places
where it should continue to be used, whose warnings should also be squashed?  If not, then
moving it to be private in HDFS makes sense.

> We could move DeprecatedUTF8 to hdfs as a package private class.

+1


> Handling javac "deprecated" warning for using UTF8
> --------------------------------------------------
>
>                 Key: HADOOP-5823
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5823
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5823.patch, HADOOP-5823.patch
>
>
> o.a.h.io.UTF8 is deprecated but is still used in multiple places. FSEditLog.java has
40 UTF8 related warnings. I don't think it is feasible to avoid using UTF8 in FSEditLog.java.

> Two options to get rid of these warnings :
>   1. use @SupressWarnings at each use of UTF or for enclosing class.
>   2. define a wrapper class {{DeprecatedUTF8}} that is not {{@deprecated}}. 
> I prefer the second option in this case since it keeps FSEditLog.java and other places
clean and still makes it explicit that a deprecated class is used.
> This is part of spring cleaning effort to remove warnings in javac. I will attach a patch
for the second option.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message