hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5737) UGI checks in testcases are broken
Date Fri, 08 May 2009 03:07:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amar Kamat updated HADOOP-5737:
-------------------------------

    Attachment: HADOOP-5737-v1.5.patch

Attaching a patch the reduces code duplication. I think its ok to pass open up jobtracker
conf as only jip requires it now. JobHistory already has it. To pass the jobtracker's fs to
JobHistory, we need to pass the jobtracker handle to JobHistory. Result of test-patch
{code}
 [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{code}
Ant tests passed on my box.

> UGI checks in testcases are broken
> ----------------------------------
>
>                 Key: HADOOP-5737
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5737
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>         Attachments: HADOOP-5737-v1.3.patch, HADOOP-5737-v1.5.patch
>
>
> While running {{TestMiniMRWithDFSWithDistinctUsers}}, I used this patch to test the ugi
checks 
> {code}
> Index: src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java
> ===================================================================
> --- src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(revision
768189)
> +++ src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(working copy)
> @@ -40,6 +40,7 @@
>      if (LOG.isDebugEnabled()) {
>        LOG.debug("ugi=" + ugi);
>      }
> +    LOG.info("ugi=" + ugi);
>  
>      if (ugi != null) {
>        user = ugi.getUserName();
> {code}
> While initializing a job, the ugi information should point to jobtracker as jobtracker
does a dfs read. But today we will see that the log shows _pi_ as the caller instead of the
jobtracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message