hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5737) UGI checks in testcases are broken
Date Thu, 07 May 2009 21:24:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707126#action_12707126
] 

Arun C Murthy commented on HADOOP-5737:
---------------------------------------

bq. For case #1, JobTracker.getFileSystem() makes sense but for case #2, its better to pass
the conf. 

How is it better to pass the conf? JobTracker.getFileSystem(path) would take the path, resolve
it against it's own conf and return the FileSystem - that way it's more explicit that you
need the JobTracker's view of the filesytem. getConf() is too generic and it's too easy to
forget to call getConf() in the future etc.

> UGI checks in testcases are broken
> ----------------------------------
>
>                 Key: HADOOP-5737
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5737
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>         Attachments: HADOOP-5737-v1.3.patch
>
>
> While running {{TestMiniMRWithDFSWithDistinctUsers}}, I used this patch to test the ugi
checks 
> {code}
> Index: src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java
> ===================================================================
> --- src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(revision
768189)
> +++ src/hdfs/org/apache/hadoop/hdfs/server/namenode/PermissionChecker.java	(working copy)
> @@ -40,6 +40,7 @@
>      if (LOG.isDebugEnabled()) {
>        LOG.debug("ugi=" + ugi);
>      }
> +    LOG.info("ugi=" + ugi);
>  
>      if (ugi != null) {
>        user = ugi.getUserName();
> {code}
> While initializing a job, the ugi information should point to jobtracker as jobtracker
does a dfs read. But today we will see that the log shows _pi_ as the caller instead of the
jobtracker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message