hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4829) Allow FileSystem shutdown hook to be disabled
Date Wed, 06 May 2009 12:42:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706397#action_12706397
] 

Hadoop QA commented on HADOOP-4829:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407279/hadoop-4829-v2.txt
  against trunk revision 772059.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/294/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/294/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/294/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/294/console

This message is automatically generated.

> Allow FileSystem shutdown hook to be disabled
> ---------------------------------------------
>
>                 Key: HADOOP-4829
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4829
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 0.18.1
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: hadoop-4829-v2.txt, hadoop-4829.txt
>
>
> FileSystem sets a JVM shutdown hook so that it can clean up the FileSystem cache. This
is great behavior when you are writing a client application, but when you're writing a server
application, like the Collector or an HBase RegionServer, you need to control the shutdown
of the application and HDFS much more closely. If you set your own shutdown hook, there's
no guarantee that your hook will run before the HDFS one, preventing you from taking some
shutdown actions.
> The current workaround I've used is to snag the FileSystem shutdown hook via Java reflection,
disable it, and then run it on my own schedule. I'd really appreciate not having to do take
this hacky approach. It seems like the right way to go about this is to just to add a method
to disable the hook directly on FileSystem. That way, server applications can elect to disable
the automatic cleanup and just call FileSystem.closeAll themselves when the time is right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message