hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5188) Modifications to enable multiple types of logging
Date Wed, 27 May 2009 21:53:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713765#action_12713765
] 

Benjamin Reed commented on HADOOP-5188:
---------------------------------------

-1 this patch is not ready for submission. here are some things to fix: 

* you left and log.info message in src/hdfs/org/apache/hadoop/hdfs/server/namenode/BackupStorage.java
* in src/hdfs/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java and src/hdfs/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
get rid of the // TODO comment and explain why it is empty
* you should remove the commented line in src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* there are two processIOError in src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSImage.java.
shouldn't there only be one?
* you are commenting out lines instead of removing them. why?
* in getCheckpointEditsDirs you can't just be doing stack traces. log the exception and handle
it.
* don't do e.printStackTrace(), pass it as a parameter to your log message
* what is the FIXME getNewInputStreamInstance?
 

> Modifications to enable multiple types of logging 
> --------------------------------------------------
>
>                 Key: HADOOP-5188
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5188
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch, HADOOP-5188.patch,
HADOOP-5188.patch, HADOOP-5188.pdf
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message