hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5838) Remove a few javac warnings under hdfs
Date Fri, 15 May 2009 00:30:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709647#action_12709647
] 

Jakob Homan commented on HADOOP-5838:
-------------------------------------

Looks good.  On line 104, can we get rid of the assert statement and just use the newly thrown
exception?  
Amazingly tiny nit: DeprecatedUTF8 has a couple misspellings in comment (in stead => instead,
SupressWarning => SuppressWarning).

Other than that, +1.

> Remove a few javac warnings under hdfs
> --------------------------------------
>
>                 Key: HADOOP-5838
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5838
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message