hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5314) needToSave incorrectly calculated in loadFSImage()
Date Fri, 08 May 2009 21:12:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707531#action_12707531

Konstantin Shvachko commented on HADOOP-5314:

The "the overly complicated statement" was intended to avoid using extra objects like HashSet.
But your approach works too.
Thanks for noting that {{editLog}} should be opened explicitly if the image was not saved.
I do not see any rational in changing the order of the imports. They were lexicographically
ordered. Could you please restore the original order.
+1 other than that.

> needToSave incorrectly calculated in loadFSImage()
> --------------------------------------------------
>                 Key: HADOOP-5314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5314
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Konstantin Shvachko
>            Assignee: Jakob Homan
>             Fix For: 0.19.2
>         Attachments: HADOOP-5314.patch
> {{FSImage.loadFSImage()}} incorrectly calculates the value of {{needToSave}}, which is
always true and results in saving image at startup even if that is not necessary.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message