Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 63871 invoked from network); 15 Apr 2009 21:12:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Apr 2009 21:12:37 -0000 Received: (qmail 30811 invoked by uid 500); 15 Apr 2009 21:12:36 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 30755 invoked by uid 500); 15 Apr 2009 21:12:36 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 30745 invoked by uid 99); 15 Apr 2009 21:12:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 21:12:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 21:12:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4A80129A0024 for ; Wed, 15 Apr 2009 14:12:15 -0700 (PDT) Message-ID: <468258429.1239829935304.JavaMail.jira@brutus> Date: Wed, 15 Apr 2009 14:12:15 -0700 (PDT) From: "Suresh Srinivas (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5671) DistCp.sameFile(..) should return true if src fs does not support checksum In-Reply-To: <1137989521.1239740594901.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699389#action_12699389 ] Suresh Srinivas commented on HADOOP-5671: ----------------------------------------- Based on the documentation of the method {{FileSystem.getFileChecksum()}}, not supporting checksum is indicated by {{null}} return and *not* by throwing exception. So should we ensure the classes extending {{FileSystem}} honor this? > DistCp.sameFile(..) should return true if src fs does not support checksum > -------------------------------------------------------------------------- > > Key: HADOOP-5671 > URL: https://issues.apache.org/jira/browse/HADOOP-5671 > Project: Hadoop Core > Issue Type: Bug > Components: tools/distcp > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: 5671_20090414.patch, 5671_20090415.patch > > > In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.