Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 29494 invoked from network); 25 Apr 2009 00:46:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Apr 2009 00:46:55 -0000 Received: (qmail 26401 invoked by uid 500); 25 Apr 2009 00:46:53 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 26327 invoked by uid 500); 25 Apr 2009 00:46:53 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 26317 invoked by uid 99); 25 Apr 2009 00:46:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Apr 2009 00:46:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Apr 2009 00:46:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C0CA7234C4AE for ; Fri, 24 Apr 2009 17:46:30 -0700 (PDT) Message-ID: <1091856802.1240620390788.JavaMail.jira@brutus> Date: Fri, 24 Apr 2009 17:46:30 -0700 (PDT) From: "Konstantin Shvachko (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5729) FSEditLog.open should stop going on if cannot open any directory In-Reply-To: <694379807.1240495770521.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702634#action_12702634 ] Konstantin Shvachko commented on HADOOP-5729: --------------------------------------------- > AFAIK processIOError() intends to deal with errors of editStreams and remove bad ones Correct. And also shutdown the node if there are no streams remained. It does it in the first line. > FSEditLog.open should stop going on if cannot open any directory > ---------------------------------------------------------------- > > Key: HADOOP-5729 > URL: https://issues.apache.org/jira/browse/HADOOP-5729 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Affects Versions: 0.19.1 > Environment: CentOS 5.2, jdk 1.6, hadoop 0.19.1 > Reporter: Wang Xu > Assignee: Wang Xu > Fix For: 0.19.2 > > Attachments: fseditlog-open.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > FSEditLog.open will be invoked when SecondaryNameNode doCheckPoint, > If no dir is opened successfully, it only prints some WARN messages in log, > and goes on running. > However, it causes the editStreams becomes empty and cannot by synced > in. And if editStreams were decreased to 0 when exceptions occured during > logsync, NameNode would print FATAL log message and halt itself. Hence, > we think it should also stopped itself at that time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.