hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nigel Daley <nda...@yahoo-inc.com>
Subject Fwd: [jira] Commented: (HADOOP-5518) MRUnit unit test library
Date Tue, 07 Apr 2009 15:06:53 GMT
Doug, I believe you committed this patch even though it got a -1 on  
Eclipse classpath.  Now every patch is getting a -1.  Can you please  
revert or fix this?

The classpath in trunk/.eclipse.templates/.classpath has to match the  
jar files in the lib directories throughout the project.

Here's a couple of the key lines from the test-patch.sh:
   export DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@ 
\1@p' < .eclipse.templates/.classpath)
   export PRESENT_JARS=$(find build/ivy/lib/Hadoop/common/ lib/ src/ 
test/lib/ -name '*.jar' |sort)


Begin forwarded message:

> From: "Hadoop QA (JIRA)" <jira@apache.org>
> Date: March 31, 2009 2:54:50 PM PDT
> To: <core-dev@hadoop.apache.org>
> Subject: [jira] Commented: (HADOOP-5518) MRUnit unit test library
> Reply-To: core-dev@hadoop.apache.org
>    [ https://issues.apache.org/jira/browse/HADOOP-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694297

> #action_12694297 ]
> Hadoop QA commented on HADOOP-5518:
> -----------------------------------
> -1 overall.  Here are the results of testing the latest attachment
>  http://issues.apache.org/jira/secure/attachment/12404202/HADOOP-5518-3.patch
>  against trunk revision 760502.
>    +1 @author.  The patch does not contain any @author tags.
>    +1 tests included.  The patch appears to include 23 new or  
> modified tests.
>    +1 javadoc.  The javadoc tool did not generate any warning  
> messages.
>    +1 javac.  The applied patch does not increase the total number  
> of javac compiler warnings.
>    +1 findbugs.  The patch does not introduce any new Findbugs  
> warnings.
>    -1 Eclipse classpath. The patch causes the Eclipse classpath to  
> differ from the contents of the lib directories.
>    +1 release audit.  The applied patch does not increase the total  
> number of release audit warnings.
>    +1 core tests.  The patch passed core unit tests.
>    -1 contrib tests.  The patch failed contrib unit tests.
> Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/84/testReport/
> Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/84/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
> Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/84/artifact/trunk/build/test/checkstyle-errors.html
> Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/84/console
> This message is automatically generated.
>> MRUnit unit test library
>> ------------------------
>>                Key: HADOOP-5518
>>                URL: https://issues.apache.org/jira/browse/HADOOP-5518
>>            Project: Hadoop Core
>>         Issue Type: New Feature
>>           Reporter: Aaron Kimball
>>           Assignee: Aaron Kimball
>>        Attachments: HADOOP-5518-2.patch, HADOOP-5518-3.patch,  
>> mrunit.patch, overview.html
>> MRUnit is a tool to help authors of MapReduce programs write unit  
>> tests.
>> Testing map() and reduce() methods requires some repeated work to  
>> mock the inputs and outputs of a Mapper or Reducer class, and  
>> ensure that the correct values are emitted to the OutputCollector  
>> based on inputs. Also, testing a mapper and reducer together  
>> requires running them with the sorted ordering guarantees made by  
>> the shuffle process.
>> This library provides the above functionality to authors of maps  
>> and reduces; it allows you to test maps, reduces, and map-reduce  
>> pairs without needing to perform all the setup and teardown work  
>> associated with running a job.
>> I believe this tool may be useful to the broader Hadoop community,  
>> so I have cleaned it up and would like to see it become a "contrib"  
>> module. My current environment is based on Hadoop 0.18, so this is  
>> the format it expects to use. It does not have support for the new  
>> Context-based interfaces for mappers/reducers.
>> I have attached the overview.html file for its javadoc, which  
>> provides more synopsis and an example of usage; I am also providing  
>> the current source code so that you can evaluate its structure.
>> Ideally with some feedback from the community this will move toward  
>> supporting the current trunk interface soon.
>> This currently works with JUnit 4; the supplied patch changes Ivy's  
>> libraries.properties file to use JUnit 4.5. I'm marking HADOOP-4901  
>> as a dependency for this reason.
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.

View raw message