hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Thomas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5615) Spec file and SRPM for building a Hadoop-0.19.1 RPM
Date Mon, 06 Apr 2009 22:54:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696287#action_12696287
] 

Michael Thomas commented on HADOOP-5615:
----------------------------------------

The update to 0.19.1 is very helpful.  But there are a number of style issues in cloudera's
spec file that I hope we can get cleaned up:

* Using %define to define the standard system directories is a bit overkill.  Use the predefined
macros %{_bindir}, %{_libdir}, etc. to get the standard system locations for these files.

* Using the hadoop binary distribution to build the rpm seems a bit backwards.  It would be
better of there was a source-only tarball on the download page to reduce the size of the src
rpm.

* On a similar note, it would be really nice to split the (nonexistent) hadoop source tarball
into a noarch and arch-specific component.  This would allow building arch and arch-specific
rpms without resorting to the "%ifarch noarch" frangments in the spec file, which can be awkward
to handle for automated build systems.

* The %changelog section is missing at the end of the spec file.

* Missing "BuildRequires: subversion" to generate the build/src/org/apache/hadoop/package-info.java
file

* Use 'getent' before creating the hadoop user to avoid errors if the user already exists
(from a directory service, for example):
getent passwd hadoop >/dev/null || \
       useradd -r -g hadoop -c "Hadoop runtime user" \
       -s /bin/bash hadoop

* Move the pid file to /var/run/hadoop/*.pid, the standard place to put pid files.

I've attaching the spec files that I've been using for hadoop and hdfs, for reference.  Mine
are probably not suitable for general use because I cut out most of the contrib packages,
and my init script doesn't support the job tracker (I'm only interested in HDFS).

> Spec file and SRPM for building a Hadoop-0.19.1 RPM
> ---------------------------------------------------
>
>                 Key: HADOOP-5615
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5615
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.19.1
>            Reporter: Ian Soboroff
>            Priority: Minor
>         Attachments: hadoop.spec
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I like the idea of Cloudera's RPMs, in that packages are convenient and the boot scripts
are very handy, but they are for a patched 0.18.3 and include other stuff.  Here I offer a
spec file for 0.19.1 without extra cruft.  It is essentially the spec from Cloudera's RPM
with suitable edits.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message