hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5699) Change org.apache.hadoop.examples.PiEstimator to use new mapreduce api.
Date Fri, 24 Apr 2009 01:53:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702205#action_12702205
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5699:
------------------------------------------------

Thanks for working on this, Amareshwari.

One minor comment:
{code}
-  public static class PiReducer extends MapReduceBase
-    implements Reducer<BooleanWritable, LongWritable, WritableComparable<?>, Writable>
{
+  public static class PiReducer extends 
+      Reducer<BooleanWritable, LongWritable, WritableComparable, Writable> {
{code}
WritableComparable should be declared as WritableComparable<?>.  It probably is not
worth to redo the patch for this nit.  I am fine if we fix this later.

> Change org.apache.hadoop.examples.PiEstimator to use new mapreduce api.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5699
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5699
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: examples
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>         Attachments: patch-5699.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message