hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5533) Recovery duration shown on the jobtracker webpage is inaccurate
Date Thu, 16 Apr 2009 05:24:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699533#action_12699533
] 

Amareshwari Sriramadasu commented on HADOOP-5533:
-------------------------------------------------

One Minor nit :
In the code change,
{noformat}
@@ -1313,7 +1320,14 @@
         }
       }
 
-      recoveryDuration = System.currentTimeMillis() - recoveryStartTime;
+      LOG.info("Took a total of " 
+               + StringUtils.formatTime(System.currentTimeMillis() 
+                                        - recoveryStartTime) 
+               + " for parsing and recovering all the jobs from history.");
+
+      recoveryDuration = System.currentTimeMillis() - recoveryProcessStartTime;
{noformat}
Two calls to System.currentTimeMillis() can be combined into one.

> Recovery duration shown on the jobtracker webpage is inaccurate
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5533
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5533
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>         Attachments: HADOOP-5533-v1.0.patch, HADOOP-5533-v1.2.patch, HADOOP-5533-v1.3.patch
>
>
> Recovery manager starts the timer once all the job history filenames are recovered. Ideally
the time to recover the filename should also be considered as part of the recovery duration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message