hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5709) Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
Date Thu, 23 Apr 2009 14:03:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701941#action_12701941
] 

Hadoop QA commented on HADOOP-5709:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12406008/hadoop-5709.patch
  against trunk revision 767699.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/232/console

This message is automatically generated.

> Remove the additional synchronization in MapTask.MapOutputBuffer.Buffer.write
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-5709
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5709
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>            Priority: Minor
>         Attachments: hadoop-5709.patch
>
>
> As part of HADOOP-5661, a synchronization was introduced to address a false positive
warning. While this does not have any impact on functionality and possibly on performance
either, it would be better to remove this synchronization and just suppress the warning from
a code maintenance point of view. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message