hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5462) Glibc double free exception thrown when chown syscall fails.
Date Tue, 07 Apr 2009 05:39:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696412#action_12696412
] 

Hemanth Yamijala commented on HADOOP-5462:
------------------------------------------

Looking good.

Minor points:

I think the setuid exe should work if the task-controller.cfg file is readable only by root.
Hence, it makes sense to change the user after loading the configuration which happens after
the first call to check_tt_root.
Another problem with the current code is that if the setuid operation fails, then we are freeing
up the configuration. But the config struct is not memset to 0. Hence it might have garbage
values and fail. I think it is better to initialize this to a zero'ed structure.

> Glibc double free exception thrown when chown syscall fails.
> ------------------------------------------------------------
>
>                 Key: HADOOP-5462
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5462
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.21.0
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: hadoop-5462-1.patch, HADOOP-5462.patch
>
>
> When setuid script's chown call fails, a glibc double free exception is thrown. The reason
for this is that file_handle which was opened to write the pid file is already closed and
the cleanup: label tries to close it once again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message