hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5743) Configuration: Hierachical; documented; null-safe; thread-safe
Date Sun, 26 Apr 2009 08:30:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702867#action_12702867
] 

Hadoop QA commented on HADOOP-5743:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12406396/02_configuration.patch
  against trunk revision 768376.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/245/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/245/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/245/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/245/console

This message is automatically generated.

> Configuration: Hierachical; documented; null-safe; thread-safe
> --------------------------------------------------------------
>
>                 Key: HADOOP-5743
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5743
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Shevek
>         Attachments: 01_configuration.patch, 02_configuration.patch
>
>
> Patch to configuration to:
> * Update documentation to match code
> * Make configurations hierarchical
> * Remove global REGISTRY of configurations
> * Adding global default does not reload child configurations
> * (Eventually) make properly thread-safe
> * Allow well-behaved overriding with nulls
> * Allow future satisfaction of ticket 5708 (with which I agree, but Doug does not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message